Glow-project Glow → 2.0

Comments and changes to this ticket

• 

  Jake Archibald December 11th, 2009 @ 12:00 PM

  • Tag set to “data, enhancement”
  • State changed from “new” to “accepted”
  • Milestone set to “2.0”

  Good idea. In the mean time:

  var decoded = glow.dom.create('<div></div>').html(encoded).text();
  

• You flagged this item as spam.
  

  Michael Stillwell May 19th, 2010 @ 03:33 PM

  In case anyone's wondering, Jake's suggestion is faster than you might think (around 10,000/sec on modern hardware).

• 

  Jake Archibald May 20th, 2010 @ 10:01 AM

  If it's something you do more than once, you can also cache the creation of the div to speed things up...

    var tmpDiv = glow.dom.create('<div></div>');
      
      function unescapeHtml(encoded) {
          return tmpDiv.html(encoded).text();
      }
  

• You flagged this item as spam.
  

  KushalP June 6th, 2010 @ 10:12 AM

  So couldn't that just be written as:

  function unescapeHTML(encoded) {
      return glow.dom.create('<div></div>').html(encoded).text();
  }
  

  My only worry is whether or not it should contain the unescaped text in a variable, destroy the created dom element and then return the text.

• You flagged this item as spam.
  

  KushalP June 6th, 2010 @ 10:51 AM

  If I was going to add this to the codebase from my Github fork, where's the glow.data object that it would go under stored?

• 

  Jake Archibald June 7th, 2010 @ 08:36 AM

  Your code example is the 'quick and dirty' way, the same one I posted in the first comment.

  The code in my second comment avoids creating and destroying the temporary div each time the function runs. This temporary div can also be used by other functions, such as escapeHtml. I guess the ideal solution would be to create the temporary div the first time it's needed, meaning it isn't taking up memory on pages that never use it.

  In Glow 2, glow.lang and glow.data have been merged into glow.util

  Cheers,
  Jake.