#181 accepted
Michael Stillwell

Remove inconsistency between sections of styleguide

Reported by Michael Stillwell | March 29th, 2010 @ 01:18 PM | in 2.0

The first rule of the "Declaring functions" section of the styleguide is "The parameter list MUST start and end with a space." However, one of the examples in the "Naming variables" section is:

glow.Banner = function(bannerText, opts) {
  // ...

Comments and changes to this ticket

  • Michael Stillwell

    Michael Stillwell March 29th, 2010 @ 01:34 PM

    Another inconsistency:

    "Writing if statements" has:

    if (condition) {

    but "Writing comments" has:

    if ( isNaN(dimension) ) {
  • Jake Archibald

    Jake Archibald March 29th, 2010 @ 02:31 PM

    • State changed from “new” to “accepted”
    • Tag set to defect, website
    • Assigned user set to “Jake Archibald”
    • Milestone set to 2.0

    Cheers for spotting these. We're going to relax the spacing rule making it more like "Use spacing to avoid adjacent left/right parenthesis and angle brackets"

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

A JavaScript Library

Shared Ticket Bins

People watching this ticket